Fix/click and hover feedback menu component pfr 781 #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrquak
approved these changes
Jan 23, 2024
|
🎉 This PR is included in version 2.176.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of the MUI Menu Item component is that the background color changes on hover, but due to a CSS rule in the styles section of the component this hover feedback is not present. In design time you don’t want to see any feedback on click or on hover, but in runtime you do want to see this. This PR fixes both visual issues. Additionally, an option has been added to change the color of the icon independently of the text.
A link to the MUI Menu component: React Menu component - Material UI.
A link to the PFR ticket: PFR-781.