Fix/improve visibility delete icon in chip autocomplete pfr 737 #3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## [2.163.1](v2.163.0...v2.163.1) (2023-10-13) ### Bug Fixes * remove bench release step from release ci-cd ([69e887f](69e887f))
Z- index box fix [PFR-707]
…kbox-PAGE-3402 Feat/fix pagestate for checkbox page 3402
# [2.165.0](v2.164.0...v2.165.0) (2023-10-17) ### Bug Fixes * existing var ([25b3a8d](25b3a8d)) ### Features * fix checkbox for state values ([5e9eced](5e9eced))
|
Before we merge this to edge, could you merge acceptance into your branch? |
stefan-betty
previously approved these changes
Oct 25, 2023
RobD-tech
dismissed
stefan-betty’s stale review
The merge-base changed after approval.
ingmar-stipriaan
previously approved these changes
Oct 31, 2023
RobD-tech
dismissed
ingmar-stipriaan’s stale review
The merge-base changed after approval.
ingmar-stipriaan
deleted the
fix/improve-visibility-delete-icon-in-chip-autocomplete-PFR-737
branch
|
🎉 This PR is included in version 2.165.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the chips in the autocomplete have a dark background color, the delete icon is not (clearly) visible.
If the background color is dark, you will apply a light color to the text within the chip and the icon should behave the same. By default, the background color of the chip is set to Light (from the theme builder). The default Material UI color for the delete icon is fine then, but as soon as the background color of the chip is changed the icon color should be the same as the text color. This was a finding when working with the design system from the police. The UI was agreed upon with UX.