Skip to content

Commit

Permalink
fix #459
Browse files Browse the repository at this point in the history
This is an error in the "unset time" validator -- should be an &&
statement instead of an || in checking for an unit'd state.
  • Loading branch information
bunnie committed Dec 6, 2023
1 parent 9ab66ee commit a365450
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions RELEASE-v0.9.md
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,7 @@ perform the Xous firmware upgrade. This requires running manual update commands,
- Harden EC against power glitches during updates (requires EC update - do not plug or unplug USB during an update until this patch is finished updating)
- Some housekeeping on the Xous wiki. Much more work is needed.
- Delay PDDB mount dialogs until all update checks are completed. This is done with a call named `is_ec_ready` and `set_ec_ready` in the `llio`. Nominally, it can be set/unset to indicate if the EC is going into an update state. Initially it is unset, and it is set by the status loop once all the update activities are completed. But it could be set later on by a routine that manually initiates EC updates (although there is no sanctioned way to do that at the moment).
- Fix validator to accept `tz_offset` == 0 as valid so long as the `utc_offset` is also not 0.

## Roadmap
- Lots of testing and bug fixes
Expand Down
2 changes: 1 addition & 1 deletion services/dns/src/time.rs
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ pub fn start_time_server() {
}
}),
Some(TimeOp::WallClockTimeInit) => xous::msg_blocking_scalar_unpack!(msg, _, _, _, _, {
if utc_offset_ms == 0 || tz_offset_ms == 0 {
if utc_offset_ms == 0 && tz_offset_ms == 0 {
xous::return_scalar(msg.sender, 0).unwrap();
} else {
xous::return_scalar(msg.sender, 1).unwrap();
Expand Down

0 comments on commit a365450

Please sign in to comment.