Merge pull request #60 from beomjo/1.0.4/merge-develop-into-main

Merge develop into main branch

.github/workflows/android.yml

@@ -5,10 +5,12 @@ on:
   #    branches: [ main, develop ]
   pull_request:
     branches: [ main, develop ]
+  schedule:
+    - cron: '* 7 * * *'
 
 jobs:
-  unit_test:
-    name: UnitTest
+  android_lint:
+    name: AndroidLint
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -25,15 +27,8 @@ jobs:
       - name: Clone Submodule
         run: git clone https://github.com/beomjo/android-compilation.git
 
-      - name: Unit Test
-        run: ./gradlew testDebugUnitTest
-
-      - name: Android Test Report
-        uses: asadmansr/[email protected]
-        if: ${{ always() }}
-        with:
-          name: reports
-          path: app/build/test-results
+      - name: Run Android Lint
+        run: ./gradlew lintRelease
 
       - name: Workflow Failed Notification to Slack
         uses: rtCamp/action-slack-notify@v2
@@ -47,10 +42,8 @@ jobs:
           SLACK_USERNAME: Github Notification
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
 
-
   ktlint:
     name: ktlint
-    needs: unit_test
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -85,7 +78,6 @@ jobs:
 
   detekt:
     name: detekt
-    needs: [ unit_test, ktlint ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -117,9 +109,52 @@ jobs:
           SLACK_USERNAME: Github Notification
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
 
+
+  unit_test:
+    name: UnitTest
+    needs: [ android_lint, ktlint, detekt ]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: set up JDK 8
+        uses: actions/setup-java@v2
+        with:
+          java-version: '8'
+          distribution: 'adopt'
+
+      - name: Grant execute permission for gradlew
+        run: chmod +x gradlew
+
+      - name: Clone Submodule
+        run: git clone https://github.com/beomjo/android-compilation.git
+
+      - name: Unit Test
+        run: ./gradlew testDebugUnitTest
+
+      - name: Android Test Report
+        uses: asadmansr/[email protected]
+        if: ${{ always() }}
+        with:
+          name: reports
+          path: app/build/test-results
+
+      - name: Workflow Failed Notification to Slack
+        uses: rtCamp/action-slack-notify@v2
+        if: ${{ failure() }}
+        env:
+          SLACK_CHANNEL: github-notification
+          SLACK_COLOR: ${{ job.status }}
+          SLACK_ICON: https://user-images.githubusercontent.com/39984656/126071498-60496f8c-4971-4bb1-9609-2cab573c1079.png
+          SLACK_MESSAGE: '[${{ github.workflow }}.${{ github.action }}] Failed!! :rage:'
+          SLACK_TITLE: Message
+          SLACK_USERNAME: Github Notification
+          SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
+
+
   build:
     name: Build
-    needs: [ unit_test, ktlint, detekt ]
+    needs: [ android_lint, ktlint, detekt, unit_test ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2

.github/workflows/upload_aab_to_play_store.yml

@@ -54,6 +54,15 @@ jobs:
       - name: Clean Project
         run: ./gradlew clean --stacktrace
 
+      - name: Run Android Lint
+        run: ./gradlew lintRelease
+
+      - name: Run ktlint
+        run: ./gradlew ktlintCheck
+
+      - name: Run detekt
+        run: ./gradlew detekt
+
       - name: Unit Test
         run: ./gradlew testDebugUnitTest
 
@@ -64,12 +73,6 @@ jobs:
           name: reports
           path: app/build/test-results # path to where the xml test results are stored
 
-      - name: Run ktlint
-        run: ./gradlew ktlintCheck
-
-      - name: Run detekt
-        run: ./gradlew detekt
-
       - name: Build AAB
         run: ./gradlew bundleRelease --stacktrace
 

.gitignore

@@ -11,3 +11,4 @@ local.properties
 .idea/gradle.xml
 .idea/vcs.xml
 .idea
+.idea/