Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AC, CCI, MACD, StochasticRSI, ADX, WSMA): Add replacing values #734

Merged
merged 19 commits into from
Jan 12, 2025
Merged

feat(AC, CCI, MACD, StochasticRSI, ADX, WSMA): Add replacing values #734

merged 19 commits into from
Jan 12, 2025

Conversation

bennycode
Copy link
Owner

@bennycode bennycode commented Dec 6, 2024 •
edited
Loading

  • ADX does not support update replace yet because DX does not support it.

@bennycode bennycode mentioned this pull request Dec 6, 2024
Closed
@bennycode bennycode marked this pull request as ready for review December 12, 2024 13:31
@bennycode bennycode changed the title fix(MACD): Fix replacing values fix(AC, MACD): Fix replacing values Dec 12, 2024
@bennycode bennycode changed the title fix(AC, MACD): Fix replacing values fix(AC, MACD, ADX): Fix replacing values Dec 12, 2024
@bennycode bennycode changed the title fix(AC, MACD, ADX): Fix replacing values fix(AC, MACD, ADX, WSMA): Fix replacing values Dec 12, 2024
@bennycode bennycode changed the title fix(AC, MACD, ADX, WSMA): Fix replacing values fix(AC, CCI, MACD, StochasticRSI, ADX, WSMA): Fix replacing values Jan 12, 2025
@bennycode bennycode changed the title fix(AC, CCI, MACD, StochasticRSI, ADX, WSMA): Fix replacing values feat(AC, CCI, MACD, StochasticRSI, ADX, WSMA): Add replacing values Jan 12, 2025
@bennycode bennycode linked an issue Jan 12, 2025 that may be closed by this pull request
update method in MACD.ts does not reflect replace argument #732
Closed
@bennycode bennycode merged commit 5f28027 into main Jan 12, 2025
3 checks passed
@bennycode bennycode deleted the fix-macd-replace branch January 12, 2025 10:44
@bennycode bennycode linked an issue Jan 13, 2025 that may be closed by this pull request
Replace and "What if" Scenarios #665
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: feature ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update method in MACD.ts does not reflect replace argument Replace and "What if" Scenarios
1 participant
@bennycode