This repository has been archived by the owner on Nov 6, 2019. It is now read-only.
Support for other accessing eBay data in the UK as well as the US #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to work, but more consistent internally. (xml is the lowest-common-denominator protocol for all the ebay APIs.)
…ate examples and readme.
…'s internal naming. (though not consistent with API header names - blah.)
+ tests for error handling. + switch parser back to callback pattern, so it gets data on error case too.
(`debug` has its own timing mechanism, comparing time between debug calls, but it's hard to follow.)
…llback. (allows default parser to be run on existing response w/o needing to re-pass the context.)
…(e.g. via curl).
…istent output formats, too dangerous. Try a blacklist approach instead with keys known to be arrays. (Tedious to implement - only done for Trading:GetOrders so far - but hopefully safer.)
…ening depth from 3 to 5.
also fix `.that.have.property()` syntax in tests, was a false positive before.
…lement their own pagination. (Logic is too endpoint- and application-specific to make sense as a generic method here.)
I used this example only to find out a few hours later the example code is outdated
GetSingleItem requires 'ItemID' as the argument (not 'ItemId')
As of 3/22/2016, the eBay API has several servers that can only
negotiate TLS v1.0 sessions, and several servers that can negotiate TLS
v1.0, v1.1 and v1.2. Node/OpenSSL get confused by this, and occasionally
attempt to parse a v1.2 response using TLS v1.0 and vice versa. The
error you get back from the request looks something like this:
```
{ [Error: write EPROTO 140113357338496:error:1408F10B:SSL
routines:SSL3_GET_RECORD:wrong version number:../deps/openssl/openssl/ssl/s3_pkt.c:362:
] code: 'EPROTO',
errno: 'EPROTO',
syscall: 'write' }
```
As far as I can tell, this isn't patched yet, in Node or OpenSSL. But
setting the following options forces all connections to be negotiated
with TLS v1.0, effectively fixing the issue.
More reading:
aws/aws-sdk-js#862
nodejs/node#3692
https://www.ssllabs.com/ssltest/analyze.html?d=api.ebay.com
If you know anyone at eBay, please tell them it's a) unacceptable to
have servers that can only negotiate TLS v1.0, and b) unacceptable to
have a SSL certificate that was signed with SHA1, and they should
upgrade both things.
Force negotiation using TLSv1.0
…lock to specific versions.
Update Shopping-GetSingleItem.js
Change appName to appId since appName no longer works
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.