Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add is_empty #79

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jorisvandenbossche
Copy link
Collaborator

Another small function I could have used for plotting (filtering out the empties after calculating the intersection with the hemisphere)

I used the s2geography available function, but actually we should probably use the cached is_empty() method on our own Geography class? @benbovy

@benbovy
Copy link
Owner

benbovy commented Nov 25, 2024

but actually we should probably use the cached is_empty() method on our own Geography class?

Yes that might be a little more efficient but not a big difference I think. For consistency, we should probably use s2geography's function to set the cached value, actually.

@benbovy benbovy added this to the 0.1.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants