Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/devsu 2449 add updates to notifications table when notifications are created completed #385

Conversation

sshugsc
Copy link
Contributor

@sshugsc sshugsc commented Sep 20, 2024

DEVSU-2449:

  • add status column to notification table
  • create/update status when notifications are created/completed

@sshugsc sshugsc requested review from elewis2 and Nithriel September 20, 2024 20:31
@sshugsc sshugsc self-assigned this Sep 20, 2024
elewis2
elewis2 previously approved these changes Oct 3, 2024

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 76.73%. Comparing base (8a2bcbc) to head (65c2046).

Files with missing lines Patch % Lines
app/queue.js 0.00% 15 Missing ⚠️
app/libs/email.js 33.33% 2 Missing ⚠️
app/routes/report/reportUser.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #385      +/-   ##
===========================================
- Coverage    76.84%   76.73%   -0.12%     
===========================================
  Files          172      172              
  Lines         5831     5850      +19     
  Branches       698      698              
===========================================
+ Hits          4481     4489       +8     
- Misses        1275     1288      +13     
+ Partials        75       73       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ations-table-when-notifications-are-created-completed

This comment has been minimized.

@sshugsc sshugsc merged commit 8d76fe8 into develop Oct 17, 2024
6 checks passed
Copy link

Unit Test Results

    1 files  ±0    60 suites  ±0   2m 41s ⏱️ +4s
550 tests ±0  550 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
547 runs  ±0  547 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8d76fe8. ± Comparison against base commit 8a2bcbc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants