Update tests

bcgsc · Nov 20, 2023 · 224fb3e · 224fb3e
1 parent c9730a2
commit 224fb3e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 10 deletions.
diff --git a/app/middleware/__mocks__/auth.js b/app/middleware/__mocks__/auth.js
@@ -10,7 +10,15 @@ module.exports = async (req, res, next) => {
 
   // Override authorization in order to mock permissions
   if (req.query.groups) {
-    req.user.groups = [req.query.groups];
+    if (typeof req.query.groups.name === 'object') {
+      req.user.groups = [];
+
+      for (const i of req.query.groups.name) {
+        req.user.groups.push({name: i});
+      }
+    } else {
+      req.user.groups = [req.query.groups];
+    }
   }
 
   if (req.query.projects) {

diff --git a/test/routes/report/report.test.js b/test/routes/report/report.test.js
@@ -45,9 +45,9 @@ const checkReports = (reports) => {
   });
 };
 
-const checkState = (reports, state) => {
+const checkState = (reports, stateCheck) => {
   return reports.some((report) => {
-    return report.state === state;
+    return report.state === stateCheck;
   });
 };
 
@@ -184,15 +184,15 @@ describe('/reports/{REPORTID}', () => {
       const res = await request
         .get('/api/reports')
         .query({
-          groups: [{name: NON_PROD_ACCESS}],
+          groups: [{name: NON_PROD_ACCESS}, {name: UNREVIEWED_ACCESS}],
           projects: [{name: project.name}],
         })
         .auth(username, password)
         .type('json')
         .expect(HTTP_STATUS.OK);
 
       checkReports(res.body.reports);
-      expect(checkState(res.body.reports, 'non-production')).toBeTruthy();
+      expect(checkState(res.body.reports, 'nonproduction')).toBeTruthy();
     }, LONGER_TIMEOUT);
 
     test('/ - 200 NOT GET non-production reports with non-authorized group', async () => {
@@ -207,14 +207,14 @@ describe('/reports/{REPORTID}', () => {
         .expect(HTTP_STATUS.OK);
 
       checkReports(res.body.reports);
-      expect(checkState(res.body.reports, 'non-production')).not.toBeTruthy();
+      expect(checkState(res.body.reports, 'nonproduction')).not.toBeTruthy();
     }, LONGER_TIMEOUT);
 
     test('/ - 200 GET report if have additional report permission', async () => {
       const res = await request
         .get('/api/reports')
         .query({
-          groups: [{name: NON_PROD_ACCESS}],
+          groups: [{name: NON_PROD_ACCESS}, {name: UNREVIEWED_ACCESS}],
           projects: [{name: project2.name}],
         })
         .auth(username, password)
@@ -417,7 +417,7 @@ describe('/reports/{REPORTID}', () => {
       const res = await request
         .get(`/api/reports/${reportDualProj.ident}`)
         .query({
-          groups: [{name: NON_PROD_ACCESS}],
+          groups: [{name: NON_PROD_ACCESS}, {name: UNREVIEWED_ACCESS}],
           projects: [{name: project2.name, ident: project2.ident}],
         })
         .auth(username, password)
@@ -431,7 +431,7 @@ describe('/reports/{REPORTID}', () => {
       const res = await request
         .get(`/api/reports/${reportNonProduction.ident}`)
         .query({
-          groups: [{name: NON_PROD_ACCESS}],
+          groups: [{name: NON_PROD_ACCESS}, {name: UNREVIEWED_ACCESS}],
           projects: [{name: project.name, ident: project.ident}],
         })
         .auth(username, password)
@@ -612,7 +612,6 @@ describe('/reports/{REPORTID}', () => {
     await db.models.report.destroy({where: {id: reportReviewed.id}, force: true});
     await db.models.report.destroy({where: {id: reportArchived.id}, force: true});
     await db.models.report.destroy({where: {id: reportNonProduction.id}, force: true});
-    await db.models.report.destroy({where: {id: reportNonProduction.id}, force: true});
   }, LONGER_TIMEOUT);
 });