Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable and remove projects in downstream #1287

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy changed the title Disabled and remove projects in downstream Disable and remove projects in downstream Dec 6, 2021
Those projects are broken due to incompatible changes in Bazel and
didn't get fixed for a long time.

* Android Testing: android/testing-samples#417
* Tulsi: bazelbuild/tulsi#286
* rules_dotnet: bazel-contrib/rules_dotnet#268
* rules_haskell: tweag/rules_haskell#1650
* rules_k8s: bazelbuild/rules_k8s#668
* rules_d: removed because the project isn't maintained.
@meteorcloudy meteorcloudy merged commit 9b1d343 into master Dec 7, 2021
@meteorcloudy meteorcloudy deleted the disable_projects branch December 7, 2021 09:40
@aherrmann
Copy link

Those projects are broken due to incompatible changes in Bazel and
didn't get fixed for a long time.

rules_haskell was only informed about this failure yesterday: tweag/rules_haskell#1650
That's a very short deadline to get a fix in place.
Is there some way to set up automatic notification for when this pipeline fails?

@meteorcloudy
Copy link
Member Author

meteorcloudy commented Dec 7, 2021

Our CI sheriff is responsible for filing issues against downstream projects, automatic notification can be very noise, because sometimes it's a Bazel bug or infra issue.

For rules_haskell, indeed I probably should give it more time, got confused with the other long standing failing projects. Sorry about that. But you can still check Bazel@HEAD + rules_haskell result at https://buildkite.com/bazel/bazel-at-head-plus-disabled/builds/1133, we can re-enable it in the actual downstream pipeline once it's green. ;)

@meteorcloudy
Copy link
Member Author

meteorcloudy commented Dec 7, 2021

@aherrmann
Wait a minute, rules_haskell isn't only failing in downstream pipeline, it's already failing with Bazel 4.2.1 since https://buildkite.com/bazel/rules-haskell-haskell/builds?branch=master&page=7.

Maybe you should put a build status badge in the README file? Something like Build status

here you go: tweag/rules_haskell#1652

@aherrmann
Copy link

Wait a minute, rules_haskell isn't only failing in downstream pipeline, it's already failing with Bazel 4.2.1 since https://buildkite.com/bazel/rules-haskell-haskell/builds?branch=master&page=7.

Oh, I missed that. Looks like perhaps something changed about the image.

    libgmp.so: cannot open shared object file: No such file or directory

Maybe you should put a build status badge in the README file? Something like Build status

here you go: tweag/rules_haskell#1652

Thanks, it's better than nothing. I'd still prefer actual notifications, though. 🙂 Just makes a timely response more likely.

@philwo
Copy link
Member

philwo commented Dec 7, 2021

@aherrmann I sent you a PR here that hopefully fixes the issue: tweag/rules_haskell#1655

fmeum pushed a commit to fmeum/continuous-integration that referenced this pull request Dec 10, 2023
Those projects are broken due to incompatible changes in Bazel and
didn't get fixed for a long time.

* Android Testing: android/testing-samples#417
* Tulsi: bazelbuild/tulsi#286
* rules_dotnet: bazel-contrib/rules_dotnet#268
* rules_haskell: tweag/rules_haskell#1650
* rules_k8s: bazelbuild/rules_k8s#668
* rules_d: removed because the project isn't maintained.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants