Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pybind11_protobuf #2074

Merged
merged 1 commit into from
May 29, 2024
Merged

Add pybind11_protobuf #2074

merged 1 commit into from
May 29, 2024

Conversation

mering
Copy link
Contributor

@mering mering commented May 21, 2024

This is using the same patches as in #2031.

As there is no release process, we are using a version string including the commit sha like it's done for boringssl as well.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (pybind11_protobuf) have been updated in this PR. Please review the changes.

@mering
Copy link
Contributor Author

mering commented May 21, 2024

@frigus02 do you accept maintainership?

@mering
Copy link
Contributor Author

mering commented May 21, 2024

@fmeum could you please trigger the tests?

@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels May 21, 2024
Copy link

@frigus02 frigus02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accept the maintainership

modules/pybind11_protobuf/metadata.json Outdated Show resolved Hide resolved
@mering mering force-pushed the add-pybind11-protobuf branch 5 times, most recently from f33ee96 to 174eba4 Compare May 21, 2024 12:50
@frigus02
Copy link

pybind/pybind11_protobuf#157 has been merged. Running bazel test //... on the pybind11_protobuf main branch succeeds now. I hope that will fix the builds here, too.

@mering mering force-pushed the add-pybind11-protobuf branch 4 times, most recently from 9da447a to abf5dbc Compare May 24, 2024 11:29
@mering
Copy link
Contributor Author

mering commented May 24, 2024

@frigus02 Awesome, thanks!

@fmeum Tests are passing now!

@mering mering force-pushed the add-pybind11-protobuf branch 4 times, most recently from 8512abe to 1e73952 Compare May 28, 2024 19:27
@mering mering requested a review from fmeum May 28, 2024 19:29
@mering
Copy link
Contributor Author

mering commented May 29, 2024

@fmeum could you please have another look? Thanks!

@fmeum fmeum merged commit 10fc92a into bazelbuild:main May 29, 2024
12 checks passed
aiuto pushed a commit to aiuto/bazel-central-registry that referenced this pull request Jun 3, 2024
This is using the same patches as in bazelbuild#2031.

As there is no release process, we are using a version string including
the commit sha like it's done for `boringssl` as well.
zaucy pushed a commit to zaucy/bazel-central-registry that referenced this pull request Jun 14, 2024
This is using the same patches as in bazelbuild#2031.

As there is no release process, we are using a version string including
the commit sha like it's done for `boringssl` as well.
@Wyverald Wyverald mentioned this pull request Jul 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants