Carbon Batcher - minor fixes

bancorprotocol · Jan 10, 2025 · 6280ced · 6280ced
1 parent b180902
commit 6280ced
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/contracts/utility/CarbonBatcher.sol b/contracts/utility/CarbonBatcher.sol
@@ -32,12 +32,9 @@ contract CarbonBatcher is Upgradeable, Utils, ReentrancyGuard, IERC721Receiver {
      */
     event FundsWithdrawn(Token indexed token, address indexed caller, address indexed target, uint256 amount);
 
-    constructor(
-        ICarbonController carbonControllerInit,
-        IVoucher voucherInit
-    ) validAddress(address(carbonControllerInit)) validAddress(address(voucherInit)) {
-        _carbonController = carbonControllerInit;
+    constructor(IVoucher voucherInit) validAddress(address(voucherInit)) {
         _voucher = voucherInit;
+        _carbonController = ICarbonController(_voucher.controller());
 
         _disableInitializers();
     }
@@ -127,6 +124,7 @@ contract CarbonBatcher is Upgradeable, Utils, ReentrancyGuard, IERC721Receiver {
 
     /**
      * @notice withdraws funds held by the contract and sends them to an account
+     * @notice note that this is a safety mechanism, shouldn't be necessary in normal operation
      *
      * requirements:
      *

diff --git a/deploy/scripts/mainnet/0018-CarbonBatcher.ts b/deploy/scripts/mainnet/0018-CarbonBatcher.ts
@@ -5,13 +5,12 @@ import { HardhatRuntimeEnvironment } from 'hardhat/types';
 const func: DeployFunction = async ({ getNamedAccounts }: HardhatRuntimeEnvironment) => {
     const { deployer } = await getNamedAccounts();
 
-    const carbonController = await DeployedContracts.CarbonController.deployed();
     const voucher = await DeployedContracts.Voucher.deployed();
 
     await deployProxy({
         name: InstanceName.CarbonBatcher,
         from: deployer,
-        args: [carbonController.address, voucher.address]
+        args: [voucher.address]
     });
 
     return true;

diff --git a/test/forge/CarbonBatcher.t.sol b/test/forge/CarbonBatcher.t.sol
@@ -43,7 +43,7 @@ contract CarbonBatcherTest is TestFixture {
         // Deploy Carbon Controller and Voucher
         setupCarbonController();
         // Deploy Carbon Batcher
-        deployCarbonBatcher(carbonController, voucher);
+        deployCarbonBatcher(voucher);
     }
 
     /**

diff --git a/test/forge/TestFixture.t.sol b/test/forge/TestFixture.t.sol
@@ -226,12 +226,12 @@ contract TestFixture is Test {
     /**
      * @dev deploys carbon batch strategies
      */
-    function deployCarbonBatcher(TestCarbonController _carbonController, TestVoucher _voucher) internal {
+    function deployCarbonBatcher(TestVoucher _voucher) internal {
         // deploy contracts from admin
         vm.startPrank(admin);
 
         // Deploy Carbon Batch Strategies
-        carbonBatcher = new CarbonBatcher(ICarbonController(address(_carbonController)), IVoucher(address(_voucher)));
+        carbonBatcher = new CarbonBatcher(IVoucher(address(_voucher)));
 
         bytes memory initData = abi.encodeWithSelector(carbonBatcher.initialize.selector);
         // Deploy Carbon Batcher proxy