classes/kernel-balena: Avoid re-building kernel modules when not signed

Setting the nostamp flag to any value, even if it is an empty string, causes the kernel modules to be rebuilt, which is contrary to the documentation: https://lists.openembedded.org/g/bitbake-devel/message/12359 Let's avoid setting it altogether on kernels which are not signed, to speed up builds. Change-type: patch Signed-off-by: Alexandru Costache <[email protected]>
balena-os · Jan 16, 2025 · d090de0 · d090de0
1 parent d752abb
commit d090de0
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/meta-balena-common/classes/kernel-balena.bbclass b/meta-balena-common/classes/kernel-balena.bbclass
@@ -1133,7 +1133,12 @@ do_sign_gpg:append () {
 
 # Parallel builds sharing state cache will mismatch singed kernel and modules
 # Avoid using cache for signed kernel modules to avoid this
-do_compile_kernelmodules[nostamp] = "${@oe.utils.conditional('SIGN_API','','','1',d)}"
+# Also, avoid having the kernel modules rebuilt even if they
+# are not signed - see https://lists.openembedded.org/g/bitbake-devel/message/12359
+python __anonymous() {
+    if d.getVar('SIGN_API'):
+        d.setVarFlag('do_compile_kernelmodules', 'nostamp', '1')
+}
 
 do_deploy:prepend () {
     SIGNING_ARTIFACTS="${SIGNING_ARTIFACTS_BASE}"