SectionedSolidHorizontal with a vertically oriented directrix #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadia-Sugar
changed the title
pjanck
requested changes
Sep 10, 2021
Comment on lines
+17
to
+19
| #13= IFCSIUNIT(*,.LENGTHUNIT.,.DECI.,.METRE.); | ||
| #14= IFCSIUNIT(*,.AREAUNIT.,.DECI.,.SQUARE_METRE.); | ||
| #15= IFCSIUNIT(*,.VOLUMEUNIT.,.DECI.,.CUBIC_METRE.); |
| #81= IFCSECTIONEDSOLIDHORIZONTAL(#75,(#83,#111),(#138,#144),.F.); | ||
| #83= IFCARBITRARYCLOSEDPROFILEDEF(.AREA.,'',#86); | ||
| #86= IFCCOMPOSITECURVE((#97,#109),$); | ||
| #88= IFCTRIMMEDCURVE(#96,(IFCPARAMETERVALUE(3.50823878194633E-15)),( |
There was a problem hiding this comment.
This seems almost 0 - would prefer to see it :)
Suggested change
| #88= IFCTRIMMEDCURVE(#96,(IFCPARAMETERVALUE(3.50823878194633E-15)),( | |
| #88= IFCTRIMMEDCURVE(#96,(IFCPARAMETERVALUE(0.)),( |
| 180.)),.T.,.PARAMETER.); | ||
| #103= IFCAXIS2PLACEMENT2D(#104,#106); | ||
| #104= IFCCARTESIANPOINT((-17.5,0.)); | ||
| #106= IFCDIRECTION((-1.,-1.22464679914735E-16)); |
There was a problem hiding this comment.
Again, seems like a zero.
Suggested change
| #106= IFCDIRECTION((-1.,-1.22464679914735E-16)); | |
| #106= IFCDIRECTION((-1.,0.)); |
| #109= IFCCOMPOSITECURVESEGMENT(.CONTINUOUS.,.T.,#100); | ||
| #111= IFCARBITRARYCLOSEDPROFILEDEF(.AREA.,'',#112); | ||
| #112= IFCCOMPOSITECURVE((#123,#134),$); | ||
| #114= IFCTRIMMEDCURVE(#122,(IFCPARAMETERVALUE(3.50823878194633E-15)),( |
There was a problem hiding this comment.
Suggested change
| #114= IFCTRIMMEDCURVE(#122,(IFCPARAMETERVALUE(3.50823878194633E-15)),( | |
| #114= IFCTRIMMEDCURVE(#122,(IFCPARAMETERVALUE(0.)),( |
Comment on lines
+85
to
+87
| #143= IFCPOINTBYDISTANCEEXPRESSION(IFCNONNEGATIVELENGTHMEASURE(8600.),$, | ||
| $,$,#75); | ||
| #144= IFCAXIS2PLACEMENTLINEAR(#143,#145,#147); |
There was a problem hiding this comment.
The IfcPolyline being the directrix, goes from (0,0) to (86,0); however the IfcSectionedSolidHorizontal goes until 8600. This needs revision - the units missmatch.
|
This is what we can read from the model, there are also some coordinates for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test
IfcSectionedSolidHorizontal with a vertically oriented directrix in world coordinates
Covered topics