add helper to verify the correct model output file exists #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglian
force-pushed
the
helper-model-output-exists
branch
2 times, most recently
from
0beb9ac to
1d9d237
Compare
NanoCode012
reviewed
Jan 9, 2025
|
I saw that you didn't change all files in e2e like Should this be changed to use your new function but pass |
winglian
force-pushed
the
helper-model-output-exists
branch
from
f80abe4 to
4067c50
Compare
djsaunde
approved these changes
Jan 10, 2025
| import pytest | ||
| from e2e.utils import check_model_output_exists |
There was a problem hiding this comment.
Nit: something weird is going on here with the sort order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a helper function to check for the output model when doing e2e training tests.
Motivation and Context
It can be cumbersome to remember which file to look for when adding the check to tests, so this handles all that logic.
How has this been tested?
update tests!
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)