CLI cleanup and documentation #2244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglian
reviewed
Jan 8, 2025
| def preprocess(config: str, **kwargs): | ||
| """Preprocess datasets before training.""" | ||
| kwargs = {k: v for k, v in kwargs.items() if v is not None} | ||
| @filter_none_kwargs |
There was a problem hiding this comment.
noob q: why do we need these?
There was a problem hiding this comment.
The filter_none_kwargs wrapper? It removes arguments that have None values, which were added by my Click option adding wrappers. I think we could probably just modify the Click option adding wrappers but this works for now.
|
I had a quick first skim, this looks great. Thanks for cleaning this up, the cli module is substantially more readable. |
| cli_args: Command line arguments | ||
| dataset_meta: Dataset metadata containing training and evaluation datasets | ||
| cfg: Config dictionary. | ||
| dataset_meta: Dataset metadata containing training and evaluation datasets. | ||
|
|
||
| Returns: | ||
| Tuple containing: |
|
Various minor nits, but LGTM! I'll let the others review+stamp. |
djsaunde
force-pushed
the
cli-refactor
branch
from
78d79ce to
28ade9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a cleanup / modularization of the code under
axolotl/cli, where previously, many of the functions were lumped together in theaxolotl/cli/__init__.pyfile.Motivation and Context
These changes allow for better organization / readability and decluttering of the
axolotl.clinamespace.How has this been tested?
CLI tests pass.
Types of changes
Added doc strings, removed dead code, refactored methods etc. out of
axolotl/cli/__init__.pyinto aptly-named modules.