assume empty lora dropout means 0.0 and add tests #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoCode012
reviewed
Jan 10, 2025
src/axolotl/utils/models.py
Outdated
| @@ -1322,7 +1322,7 @@ def load_lora(model, cfg, inference=False, config_only=False): | |||
| target_modules=lora_target_modules, | |||
| layers_to_transform=cfg.peft_layers_to_transform, | |||
| layers_pattern=cfg.peft_layers_pattern, | |||
| lora_dropout=cfg.lora_dropout, | |||
| lora_dropout=cfg.lora_dropout if cfg.lora_dropout is not None else 0.0, | |||
There was a problem hiding this comment.
Could we perhaps move this higher up in stack? Maybe to the validation stage instead? I think it's better to centralize this.
tests/test_lora.py
Outdated
| } | ||
| ) | ||
| normalize_config(cfg) | ||
| cli_args = TrainerCliArgs() |
There was a problem hiding this comment.
Do we need to create this cli_args? Seems like you could just pass boolean to load_model below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous behavior would fail if lora_dropout was None/null. This sets it as 0.0 at runtime if it is null.