Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error on null mqtt5 client #369

Closed
wants to merge 2 commits into from
Closed

Raise error on null mqtt5 client #369

wants to merge 2 commits into from

Conversation

xiazhvera
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 82.56%. Comparing base (ed7bbd6) to head (5a78a56).

Files Patch % Lines
source/v5/mqtt5_client.c 46.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   82.62%   82.56%   -0.07%     
==========================================
  Files          20       20              
  Lines        8758     8768      +10     
==========================================
+ Hits         7236     7239       +3     
- Misses       1522     1529       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfod
Copy link
Contributor

sfod commented Jun 5, 2024

This PR relaxes the requirements for mqtt5 client to be valid, for some operations. I'm trying to figure out if this could potentially cause something bad in operations that don't validate client (e.g. https://github.com/awslabs/aws-c-mqtt/blob/v0.10.4/source/v5/mqtt5_client.c#L2109). Maybe I'm being too paranoid.

@xiazhvera
Copy link
Contributor Author

xiazhvera commented Jun 5, 2024

The PR was to workaround the swift error issue. As there are some concern about adding the error in c-mqtt, I will re-evaluate the solution. Temporary close the pr.

@xiazhvera xiazhvera closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants