All flush failures are retryable except for timestamp formatting. Fix… #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… concurrent retries failure message. Signed-off-by: Wesley Pettit <[email protected]>
matthewfala
reviewed
Mar 7, 2023
Comment on lines
295
to
301
| func (outputPlugin *OutputPlugin) FlushAggregatedRecords(records *[]*kinesis.PutRecordsRequestEntry) int { | ||
|
|
||
| aggRecord, err := outputPlugin.aggregator.AggregateRecords() | ||
| if err != nil { | ||
| logrus.Errorf("[kinesis %d] Failed to aggregate record %v\n", outputPlugin.PluginID, err) | ||
| return fluentbit.FLB_ERROR | ||
| return fluentbit.FLB_RETRY | ||
| } |
There was a problem hiding this comment.
Hmm. Not sure about this one... If aggregation fails once, won't it probably fail again the next time?
There was a problem hiding this comment.
Good point, we could spend more time investigating this, I don't have time right now with higher priority issues.
If there is any way for it to fail and not fail again then we should always return FLB_RETRY so I think if we don't know then we should return retry.
There was a problem hiding this comment.
No comment on it in original PR :/ #60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… concurrent retries failure message.
Issue #, if available:
Fixing this is low priority.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.