Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws_common): removed JS streamed requests #5797

Merged
merged 3 commits into from
Jan 13, 2025
Merged

fix(aws_common): removed JS streamed requests #5797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e74b6ae
fix(aws_common): removed JS streamed requests
tyllark Jan 10, 2025
a413ab2
chore(core,datastore,authenticator,common): fixed linter warnings
tyllark Jan 13, 2025
2e2f191
chore(datastore,authenticator,common): fixed linter errors
tyllark Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/amplify_core/lib/src/types/auth/attribute/auth_user_attribute_key.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import 'package:meta/meta.dart';
/// {@template amplify_core.auth_user_attribute_key}
/// A user attribute identifier.
/// {@endtemplate}
/// {@hideConstantImplementations}
@immutable
abstract class AuthUserAttributeKey
with
Expand Down
1 change: 0 additions & 1 deletion packages/amplify_core/lib/src/types/auth/attribute/cognito_user_attribute_key.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import 'package:amplify_core/amplify_core.dart';
/// [here](https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-settings-attributes.html).
///
/// Use [CognitoUserAttributeKey.custom] to create a custom Cognito attribute.
/// {@hideConstantImplementations}
class CognitoUserAttributeKey extends AuthUserAttributeKey {
const CognitoUserAttributeKey._(this._key, {this.readOnly = false})
: isCustom = false;
Expand Down
3 changes: 1 addition & 2 deletions packages/amplify_datastore/lib/src/utils/native_api_helpers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import 'dart:convert';

import 'package:amplify_core/amplify_core.dart';
import 'package:amplify_datastore/src/native_plugin.g.dart';
import 'package:collection/collection.dart';

/// Convert a [NativeGraphQLResponse] to a [GraphQLResponse]
GraphQLRequest<String> nativeRequestToGraphQLRequest(
Expand Down Expand Up @@ -85,7 +84,7 @@ NativeGraphQLResponse graphQLResponseToNativeResponse(
/// from a [GraphQLResponse]
String _buildPayloadJson(GraphQLResponse<String> response) {
final data = jsonDecode(response.data ?? '{}');
final errors = response.errors.whereNotNull().map((e) => e.toJson()).toList();
final errors = response.errors.nonNulls.map((e) => e.toJson()).toList();
return jsonEncode({
'data': data,
'errors': errors,
Expand Down
5 changes: 0 additions & 5 deletions packages/api/amplify_api_dart/lib/src/graphql/factories/graphql_request_factory.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,6 @@ class GraphQLRequestFactory {
upperOutput = '(\$filter: ModelSubscription${modelName}FilterInput)';
lowerOutput = r'(filter: $filter)';
}
default:
throw const ApiOperationException(
'GraphQL Request Operation is currently unsupported',
recoverySuggestion: 'please use a supported GraphQL operation',
);
}

return DocumentInputs(upperOutput, lowerOutput);
Expand Down
2 changes: 0 additions & 2 deletions packages/authenticator/amplify_authenticator/lib/src/blocs/auth/auth_bloc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,6 @@ class StateMachineBloc
}
}
yield* _checkUserVerification();
default:
break;
}
} on AuthNotAuthorizedException {
/// The .failAuthentication flag available in the DefineAuthChallenge Lambda trigger
Expand Down
1 change: 0 additions & 1 deletion packages/authenticator/amplify_authenticator/lib/src/screens/authenticator_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ class _FormWrapperView extends StatelessAuthenticatorComponent {
form,
],
);
break;
}

return Padding(padding: padding, child: layout);
Expand Down
2 changes: 0 additions & 2 deletions ...s/authenticator/amplify_authenticator/lib/src/widgets/form_fields/sign_in_form_field.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,6 @@ class _SignInTextFieldState extends _SignInFormFieldState<String>
return (v) => state.username = v;
case SignInField.password:
return (v) => state.password = v;
default:
return super.onChanged;
}
}

Expand Down
8 changes: 1 addition & 7 deletions packages/aws_common/lib/src/http/aws_http_client_js.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,7 @@ class AWSHttpClientImpl extends AWSHttpClient {
requestProgressController.close();
},
).takeUntil(cancelTrigger.future);
Object body;
if (request.scheme == 'http' ||
supportedProtocols.supports(AlpnProtocol.http1_1)) {
body = Uint8List.fromList(await collectBytes(stream));
} else {
body = stream;
}
final body = Uint8List.fromList(await collectBytes(stream));

if (completer.isCanceled) return;
final resp = await fetch(
Expand Down
Loading