Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix flaky api e2e test #4017

Merged
merged 4 commits into from
Oct 27, 2023
Merged

chore: fix flaky api e2e test #4017

merged 4 commits into from
Oct 27, 2023

Conversation

Jordan-Nelson
Copy link
Member

@Jordan-Nelson Jordan-Nelson commented Oct 27, 2023

Issue #, if available:

Description of changes:

  • Add a limit to ModelQueries.list operations that expect a certain model in the response.

Tests that use ModelQueries.list and expect certain models in the response can fail if the DB has a large number of items in it. Models are cleaned up after tests complete, but during test execution the number of models can increase past the default limit.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jordan-Nelson Jordan-Nelson changed the title chore: flaky api test chore: fix flaky api e2e test Oct 27, 2023
@Jordan-Nelson Jordan-Nelson marked this pull request as ready for review October 27, 2023 17:22
@Jordan-Nelson Jordan-Nelson requested a review from a team as a code owner October 27, 2023 17:22
@Jordan-Nelson Jordan-Nelson merged commit a84d78e into main Oct 27, 2023
12 checks passed
@Jordan-Nelson Jordan-Nelson deleted the chore/flaky-api-test branch October 27, 2023 17:53
Equartey pushed a commit that referenced this pull request Oct 30, 2023
* chore: force api tests to run

* chore: add limit

* chore: update limit

* chore: add limit to other tests
Equartey pushed a commit that referenced this pull request Oct 30, 2023
* chore: force api tests to run

* chore: add limit

* chore: update limit

* chore: add limit to other tests
khatruong2009 pushed a commit that referenced this pull request Nov 7, 2023
* chore: force api tests to run

* chore: add limit

* chore: update limit

* chore: add limit to other tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants