Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint rule for cause propagation when wrapping errors #2426

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ShadowCat567
Copy link
Contributor

@ShadowCat567 ShadowCat567 commented Jan 15, 2025

Problem

No lint rule in place to ensure that we are propagating the underlying cause for errors we wrap in AmplifyErrors

Changes

Added lint rule that mandates cause is added to AmplifyErrors in certain packages

Validation

Added new tests, lint fails if an AmplifyFault or AmplifyUserError is declared without a cause property in packages where the lint rule is turned on.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: cfc1996

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ShadowCat567 ShadowCat567 marked this pull request as ready for review January 15, 2025 22:35
@ShadowCat567 ShadowCat567 requested a review from a team as a code owner January 15, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant