feat: add --all flag to remove all secrets in sandbox #2423
+98
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Support the --all flag on sandbox secret remove to remove all secrets in a single command
Issue number, if available:
#2257
Changes
I change to use
yargs.command
instead ofyargs.positional
to handling thesecret-name
argument.We can not set
secret-name
as optional argument when useyargs.positional
without default value.Instead of we can set
secret-name
as optional argument that using[secret-name]
syntax inyargs.command
Corresponding docs PR, if applicable:
Validation
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.