refactor: params/extras (coreth a7f7061) #1430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
commented
Jan 22, 2025
| @@ -15,8 +16,7 @@ import ( | |||
|
|
|||
| func TestVerifyUpgradeConfig(t *testing.T) { | |||
| admins := []common.Address{{1}} | |||
| chainConfigCpy := Copy(TestChainConfig) | |||
| chainConfig := GetExtra(&chainConfigCpy) | |||
| chainConfig := &ChainConfig{} | |||
There was a problem hiding this comment.
note I tried to use the empty ChainConfig (former ChainConfigExtra) where possible
We can switch back to TestChainConfig if others prefer.
Less test setup seems preferred to me, but we could keep it to avoid any risk here.
| ) | ||
|
|
||
| var ( | ||
| DefaultFeeConfig = commontype.FeeConfig{ |
There was a problem hiding this comment.
I moved this so it can be used in tests, but also put it back in it's original location to avoid having to change all params.DefaultFeeConfig's in the code.
| AvalancheContext: AvalancheContext{utils.TestSnowContext()}, | ||
| FeeConfig: DefaultFeeConfig, | ||
| AllowFeeRecipients: false, | ||
| NetworkUpgrades: GetDefaultNetworkUpgrades(upgrade.GetConfig(constants.UnitTestID)), // This can be changed to correct network (local, test) via VM. |
There was a problem hiding this comment.
note we could unexport this GetDefaultNetworkUpgrades if we had something like GetDefaultExtras(networkID), but seems mostly the same to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the same changes as were applied to coreth here: ava-labs/coreth@a7f7061
I realized we could import most of these types back to params if we wanted, but explicit seems clearer + it's already like this in coreth.