atomic syncer: simplify interface #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
previously approved these changes
Jan 7, 2025
ceyonur
previously approved these changes
Jan 9, 2025
qdm12
approved these changes
Jan 9, 2025
ceyonur
approved these changes
Jan 9, 2025
qdm12
pushed a commit
that referenced
this pull request
Jan 10, 2025
Co-authored-by: Ceyhun Onur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Not sure if this is in line with #723 or somehow conflicts, but I think this is a good simplification so the atomic backend doesn't have to import the syncclient package (which imports quite some packages like core/types)
How this works
Inlines calls to newAtomicSyncer
How this was tested
CI
Need to be documented?
No
Need to update RELEASES.md?
No