Use new local-signer package #716
Open
+29
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpringle
requested review from
ceyonur,
darioush and
a team
as code owners
richardpringle
commented
Dec 20, 2024
utils/snow.go
Outdated
| @@ -13,7 +13,7 @@ import ( | |||
| "github.com/ava-labs/avalanchego/snow/validators" | |||
| "github.com/ava-labs/avalanchego/snow/validators/validatorstest" | |||
| "github.com/ava-labs/avalanchego/utils/constants" | |||
| "github.com/ava-labs/avalanchego/utils/crypto/bls" | |||
| "github.com/ava-labs/avalanchego/utils/crypto/bls/signers/local" | |||
There was a problem hiding this comment.
Should I rename this to localSigner or something similar?
There was a problem hiding this comment.
Preferrably localsigner all in lowercase
qdm12
previously approved these changes
Dec 30, 2024
|
Tests need to be updated for imports: https://github.com/ava-labs/coreth/actions/runs/12436458610/job/34724339849?pr=716 🙏 |
darioush
reviewed
Jan 6, 2025
darioush
approved these changes
Jan 6, 2025
ceyonur
approved these changes
Jan 7, 2025
qdm12
requested changes
Jan 7, 2025
| @@ -6,4 +6,4 @@ | |||
| set -euo pipefail | |||
|
|
|||
| # Don't export them as they're used in the context of other calls | |||
| AVALANCHE_VERSION=${AVALANCHE_VERSION:-'902377d447ba'} | |||
| AVALANCHE_VERSION=${AVALANCHE_VERSION:-'8885a5c44'} | |||
There was a problem hiding this comment.
Why is the short commit hash here shorter than the previous existing one? (12 vs 9 characters)
Let's keep it as it was ideally?
There was a problem hiding this comment.
It needs to be 8 bytes in subnet-evm to match the avalanchego docker tag. So let's keep it 8 here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
I've moved specific signing implementations outside of the
blspackageHow this was tested
No functional changes, so just unit tests
Need to be documented?
Nope
Need to update RELEASES.md?
Nope