-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update vehicle interface with some samples #453
Merged
mitsudome-r
merged 5 commits into
autowarefoundation:main
from
leo-drive:ismet/doc/update-vehicle-interface
Nov 17, 2023
Merged
docs: update vehicle interface with some samples #453
mitsudome-r
merged 5 commits into
autowarefoundation:main
from
leo-drive:ismet/doc/update-vehicle-interface
Nov 17, 2023
+461
−249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismetatabay
changed the title
init vehicle interface
docs: update vehicle interface with some samples
Sep 14, 2023
ismetatabay
force-pushed
the
ismet/doc/update-vehicle-interface
branch
6 times, most recently
from
September 14, 2023 15:54
f9f64be
to
a065ff3
Compare
ismetatabay
added
the
tag:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
label
Sep 14, 2023
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
force-pushed
the
ismet/doc/update-vehicle-interface
branch
from
September 15, 2023 10:06
a065ff3
to
25c8556
Compare
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
force-pushed
the
ismet/doc/update-vehicle-interface
branch
from
September 22, 2023 07:41
12c4334
to
fcb6f35
Compare
@mitsudome-r, Hi mitsudome-san this PR is ready for review. |
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
force-pushed
the
ismet/doc/update-vehicle-interface
branch
from
October 2, 2023 08:08
fcb6f35
to
345a97a
Compare
mitsudome-r
reviewed
Oct 6, 2023
docs/how-to-guides/integrating-autoware/creating-vehicle-interface-package/.pages
Outdated
Show resolved
Hide resolved
docs/how-to-guides/integrating-autoware/creating-vehicle-interface-package/vehicle-interface.md
Show resolved
Hide resolved
docs/how-to-guides/integrating-autoware/creating-vehicle-interface-package/vehicle-interface.md
Outdated
Show resolved
Hide resolved
...guides/integrating-autoware/creating-vehicle-interface-package/creating-vehicle-interface.md
Outdated
Show resolved
Hide resolved
Signed-off-by: ismetatabay <[email protected]>
Hi @mitsudome-r san, thank you for valuable comments. I updated document according to the your reviews 👍 |
This was referenced Oct 18, 2023
mitsudome-r
approved these changes
Nov 17, 2023
ismetatabay
added a commit
to leo-drive/autoware-documentation
that referenced
this pull request
Dec 26, 2023
) * init vehicle interface Signed-off-by: ismetatabay <[email protected]> * add table formatting Signed-off-by: ismetatabay <[email protected]> * update differential drive doc Signed-off-by: ismetatabay <[email protected]> * update structure, add missing example Signed-off-by: ismetatabay <[email protected]> --------- Signed-off-by: ismetatabay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates vehicle interface documentation with more information.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.