New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/hash-synch-switching-machines #147

Closed

Xm0onh wants to merge 3 commits into main from bug/hash-sync

Member

Xm0onh commented Jan 16, 2025

This PR should resolve #140.

Xm0onh added 2 commits

January 16, 2025 12:38


          address issue #140

91c06dc


          format check for pr #147

ce4318c

Xm0onh requested a review from jfrank-summit

January 16, 2025 20:41


          fix lint error

b50baa1

Member

jfrank-summit commented Jan 16, 2025 •

edited

Loading

Deleting the local hash on startup could potentially cause problems in failure scenarios. Consider the following:

Agent starts up
Agent generates new memories/hash
Update to blockchain fails (RPC down, wallet out of funds for gas, etc.)
Local hash is correctly maintained
Agent restarts
If we delete local hash on startup
Query blockchain -> get outdated state

In this case, we'd lose track of the actual last valid hash, making it impossible to maintain proper memory chain continuity.

Xm0onh closed this

Xm0onh deleted the bug/hash-sync branch

January 17, 2025 08:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet