Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #114

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Add support for Python 3.12 #114

merged 3 commits into from
Dec 16, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Dec 16, 2024

Closes #108

Adds Python 3.12 as supported version to the Python package and enables tests for it in Ubuntu runners.

Summary by Sourcery

Add support for Python 3.12 and update dependencies. Enable CI testing for Python 3.12 on Ubuntu.

New Features:

  • Add support for Python 3.12 in the project.

Enhancements:

  • Update dependencies to 'audobject >=0.7.11' and 'audinterface >=1.2.3'.

CI:

  • Enable testing for Python 3.12 on Ubuntu runners in the CI workflow.

Copy link
Contributor

sourcery-ai bot commented Dec 16, 2024

Reviewer's Guide by Sourcery

This PR adds Python 3.12 support by updating the package metadata and CI configuration. It also includes dependency updates for audobject and audinterface packages to their latest compatible versions.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added Python 3.12 as a supported Python version
  • Added Python 3.12 classifier to package metadata
  • Added Python 3.12 to the CI test matrix
pyproject.toml
.github/workflows/test.yml
Updated package dependencies to latest versions
  • Updated audobject from >=0.6.1 to >=0.7.11
  • Updated audinterface from >=0.7.0 to >=1.2.3
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you clarify why the dependency versions need to be updated? If these updates aren't strictly required for Python 3.12 support, consider splitting them into a separate PR.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hagenw hagenw merged commit e1a552e into main Dec 16, 2024
16 checks passed
@hagenw hagenw deleted the python-3.12 branch December 16, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for python3.12
1 participant