Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit in pd.to_timedelta() #10

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Fix unit in pd.to_timedelta() #10

merged 1 commit into from
Jun 7, 2021

Conversation

frankenjoe
Copy link
Collaborator

@frankenjoe frankenjoe commented Jun 7, 2021 •
edited
Loading

Use unit='s' instead of 'sec' when converting seconds with pd.to_timedelta().

Reason: it seems that some (older?) versions of pandas do not support 'sec', see e.g. audeering/opensmile-python#32 (comment)

@frankenjoe frankenjoe requested a review from hagenw June 7, 2021 08:47
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #10 (d4dfb13) into master (a5d79fe) will not change coverage.
The diff coverage is 100.0%.

Impacted Files Coverage Δ
audinterface/core/process.py 100.0% <100.0%> (ø)
audinterface/core/utils.py 100.0% <100.0%> (ø)

@hagenw
Copy link
Member

hagenw commented Jun 7, 2021

Must indeed be older versions of pandas, compare:

But I still think it is a good idea to change it.

@hagenw hagenw merged commit c8cc4e2 into master Jun 7, 2021
@hagenw hagenw deleted the fix-timedelta-unit branch June 7, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hagenw hagenw Awaiting requested review from hagenw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankenjoe @hagenw