This repository has been archived by the owner on Jan 3, 2019. It is now read-only.
Fix Tree-Sitter JavaScript highlighting for JSX file #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also apply to standard JavaScript files, but specifically,
JSX syntax highlighting has been struggling.
Description of the Change
As noted in #100, there's a lot of highlighting missing when Tree-Sitter is enabled for JavaScript. The focus of this PR is to address many of those changes and provide much needed color. It doesn't fix everything perfectly. In atom/language-javascript, there's an issue (atom/language-javascript#618) that covers adding highlighting back for language keywords (such as
this
andsuper
).Before
After
Alternate Designs
None.
Benefits
JavaScript highlighting is improved.
Possible Drawbacks
None.
Applicable Issues
#100