no basePath for external links

atlassian-labs · Dec 16, 2024 · 739eeec · 739eeec
1 parent da89d17
commit 739eeec
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/ui/link/index.tsx b/src/ui/link/index.tsx
@@ -72,8 +72,9 @@ const Link = forwardRef<HTMLButtonElement | HTMLAnchorElement, LinkProps>(
               )) ||
             ''
           : to;
+    const IS_EXTERNAL_LINK_REGEX = /^(?:(http|https):\/\/)/;
     const staticBasePath =
-      href != null || typeof to === 'string' ? routeAttributes.basePath : '';
+      (href != null && !IS_EXTERNAL_LINK_REGEX.test(href)) || typeof to === 'string' ? routeAttributes.basePath : '';
 
     const triggerPrefetch = useCallback(() => {
       // ignore if async route not ready yet

diff --git a/src/ui/link/test.tsx b/src/ui/link/test.tsx
@@ -91,7 +91,7 @@ describe('<Link />', () => {
     );
   });
 
-  it('should push history with correct link for href when given basePath', () => {
+  it('should push history with correct link for relative href when given basePath', () => {
     renderInRouter(
       'my link',
       {
@@ -105,6 +105,20 @@ describe('<Link />', () => {
     );
   });
 
+  it('should not add basePath for external links', () => {
+    renderInRouter(
+      'my link',
+      {
+        href: 'https://www.atlassian.com/',
+      },
+      '/base'
+    );
+    expect(screen.getByRole('link', { name: 'my link' })).toHaveAttribute(
+      'href',
+      'https://www.atlassian.com/'
+    );
+  });
+
   it('should pass props to the child element', () => {
     renderInRouter('my link', {
       ...defaultProps,