Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typing imports for List, Tuple, Union #441

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Closes #406.

We still have statements like:

from typing import Iterable, Optional, Callable, Type, TYPE_CHECKING
from typing_extensions import Self

Copy link

github-actions bot commented Dec 4, 2024

Before [e3d899a] <v0.4.5> After [28e619f] Ratio Benchmark (Parameter)
1.03±0.03ms 1.03±0.02ms 1.01 benchmarks.time_test_cone_filter_multiple_order
367±3ms 368±1ms 1 benchmarks.Suite.time_outer_pixel_alignment
40.0±0.4ms 39.9±0.7ms 1 benchmarks.Suite.time_pixel_tree_creation
116±0.3ms 116±0.6ms 1 benchmarks.time_test_alignment_even_sky
13.4±0.5ms 13.3±0.5ms 0.99 benchmarks.Suite.time_inner_pixel_alignment
19.5±0.1ms 19.1±0.1ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order6
77.2±0.5ms 75.8±0.4ms 0.98 benchmarks.MetadataSuite.time_load_partition_join_info
78.1±0.4ms 76.1±0.7ms 0.97 benchmarks.MetadataSuite.time_load_partition_info_order7

Click here to view all benchmarks.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.24%. Comparing base (e3d899a) to head (31ea4a8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/hats/pixel_math/filter.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
- Coverage   93.26%   93.24%   -0.03%     
==========================================
  Files          47       47              
  Lines        2034     2012      -22     
==========================================
- Hits         1897     1876      -21     
+ Misses        137      136       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit f21c1fb into main Dec 9, 2024
11 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/406/typing branch December 9, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove from typing import List and use list instead
2 participants