Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding http header possibility #411

Closed
wants to merge 1 commit into from
Closed

Conversation

Schwarzam
Copy link
Contributor

#410

I added some kwargs to be able to pass storage_options to get_upath().
That allows access to protected data in servers for example.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (8e1d456) to head (5e8cc98).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
+ Coverage   92.69%   92.89%   +0.19%     
==========================================
  Files          49       49              
  Lines        2095     2097       +2     
==========================================
+ Hits         1942     1948       +6     
+ Misses        153      149       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 1, 2024

Before [bccf40c] After [e58862d] Ratio Benchmark (Parameter)
13.4±0.6ms 14.6±1ms 1.09 benchmarks.Suite.time_inner_pixel_alignment
22.6±0.08ms 22.9±0.3ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order6
1.03±0.02ms 1.05±0.03ms 1.01 benchmarks.time_test_cone_filter_multiple_order
94.2±0.3ms 94.4±0.2ms 1 benchmarks.MetadataSuite.time_load_partition_join_info
387±1ms 386±2ms 1 benchmarks.Suite.time_outer_pixel_alignment
110±0.8ms 110±0.7ms 1 benchmarks.Suite.time_paths_creation
45.8±0.8ms 45.9±0.3ms 1 benchmarks.Suite.time_pixel_tree_creation
95.1±0.7ms 94.1±0.3ms 0.99 benchmarks.MetadataSuite.time_load_partition_info_order7
125±0.6ms 124±0.5ms 0.99 benchmarks.time_test_alignment_even_sky

Click here to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant