Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook for generating test data #231

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Notebook for generating test data #231

merged 3 commits into from
Mar 1, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

This is a deceptively large PR, but not all that much is changing!!

With recent changes to the format and to the importer, this re-generates ALL of the unit test catalog data. This does this through the new jupyter notebook. After this change, if you run the entire notebook, the only changed files should be provenance_info.json file changes (which are noisy changes).

Also sneaks in a change to move the catalogs that only contain catalog_info.json files into their own directory, for tidiness.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (de86705) to head (a0c0d25).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          57       57           
  Lines        1976     1985    +9     
=======================================
+ Hits         1975     1984    +9     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 1, 2024

Before [d2a4d0a] After [0975296] Ratio Benchmark (Parameter)
80.7±0.4ms 81.1±0.4ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order7
650±7ms 651±5ms 1 benchmarks.Suite.time_pixel_tree_creation
125±0.8ms 124±0.8ms 1 benchmarks.time_test_alignment_even_sky
81.5±0.6ms 80.7±0.5ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info
98.9±0.7ms 98.1±1ms 0.99 benchmarks.time_test_cone_filter_multiple_order
20.8±0.2ms 20.4±0.1ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order6

Click here to view all benchmarks.

tests/data/generate_data.ipynb Outdated Show resolved Hide resolved
@delucchi-cmu delucchi-cmu merged commit 85ec4a0 into main Mar 1, 2024
11 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/regen branch March 1, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants