Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset factory method #216

Merged
merged 7 commits into from
Feb 19, 2024
Merged

Dataset factory method #216

merged 7 commits into from
Feb 19, 2024

Conversation

camposandro
Copy link
Contributor

@camposandro camposandro commented Feb 16, 2024

Creates a factory method to read appropriately-typed datasets according to information in their catalog_info. A catalog can now be instantiated with hc.read_from_hipscat("/path"). Closes #190.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@camposandro camposandro self-assigned this Feb 16, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb38ea3) 99.94% compared to head (c33a552) 99.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          55       57    +2     
  Lines        1954     1976   +22     
=======================================
+ Hits         1953     1975   +22     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 16, 2024

Before [cb38ea3] After [a3a5547] Ratio Benchmark (Parameter)
19.8±0.5ms 20.0±0.2ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order6
81.0±1ms 81.5±0.8ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order7
80.1±0.3ms 80.1±0.4ms 1 benchmarks.MetadataSuite.time_load_partition_join_info
652±3ms 648±2ms 0.99 benchmarks.Suite.time_pixel_tree_creation
126±0.5ms 125±0.6ms 0.99 benchmarks.time_test_alignment_even_sky
98.6±0.9ms 97.6±0.6ms 0.99 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

@camposandro camposandro force-pushed the sandro/catalog-factory-method branch from 17f4455 to 1132037 Compare February 16, 2024 21:15
@camposandro camposandro merged commit a051d36 into main Feb 19, 2024
11 checks passed
@camposandro camposandro deleted the sandro/catalog-factory-method branch February 19, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easier instantiation of a catalog
2 participants