Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Margin Catalog #199

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Add Margin Catalog #199

merged 7 commits into from
Jan 31, 2024

Conversation

smcguire-cmu
Copy link
Contributor

Change Description

Adds the MarginCatalog class to represent a margin cache catalog. This uses the HealpixDataset base class and specifies the corresponding catalog info type. Removes margin as an option for the catalog type of a base Catalog

  • My PR includes a link to the issue that I am addressing

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffa8352) 99.72% compared to head (d3237da) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #199      +/-   ##
===========================================
+ Coverage   99.72%   100.00%   +0.27%     
===========================================
  Files          53        54       +1     
  Lines        1811      1844      +33     
===========================================
+ Hits         1806      1844      +38     
+ Misses          5         0       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 29, 2024

Before [3a77c01] After [bacbe89] Ratio Benchmark (Parameter)
326±5ms 292±20ms ~0.89 benchmarks.MetadataSuite.time_load_partition_info_order6
645±4ms 656±9ms 1.02 benchmarks.Suite.time_pixel_tree_creation
1.15±0s 1.16±0s 1.01 benchmarks.MetadataSuite.time_load_partition_info_order7
1.89±0.01s 1.90±0.01s 1.01 benchmarks.MetadataSuite.time_load_partition_join_info
98.4±0.8ms 99.7±2ms 1.01 benchmarks.time_test_cone_filter_multiple_order
126±2ms 124±0.3ms 0.98 benchmarks.time_test_alignment_even_sky

Click here to view all benchmarks.

Copy link
Contributor

@delucchi-cmu delucchi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the suggestion is ok, then this is approved.

tests/data/small_sky_order1_margin/README.md Show resolved Hide resolved
@smcguire-cmu smcguire-cmu merged commit 22467ac into main Jan 31, 2024
12 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/margin-catalog branch January 31, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants