-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract file-finding for partition info reading. #196
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
===========================================
+ Coverage 99.72% 100.00% +0.27%
===========================================
Files 53 53
Lines 1811 1831 +20
===========================================
+ Hits 1806 1831 +25
+ Misses 5 0 -5 ☔ View full report in Codecov by Sentry. |
Click here to view all benchmarks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left some minor comments!
Change Description
Related to astronomy-commons/lsdb#107
Extracts the logic to pick which partition info file to read to just exist in the
PartitionInfo
, just for code isolation. Follow-up PRs will potentially add new files/formats for storing the partition info for faster access.