Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract file-finding for partition info reading. #196

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Related to astronomy-commons/lsdb#107

Extracts the logic to pick which partition info file to read to just exist in the PartitionInfo, just for code isolation. Follow-up PRs will potentially add new files/formats for storing the partition info for faster access.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3358fbc) 99.72% compared to head (a8cb2b9) 100.00%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #196      +/-   ##
===========================================
+ Coverage   99.72%   100.00%   +0.27%     
===========================================
  Files          53        53              
  Lines        1811      1831      +20     
===========================================
+ Hits         1806      1831      +25     
+ Misses          5         0       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 22, 2024

Before [ffa8352] <v0.2.3> After [d9606b9] Ratio Benchmark (Parameter)
300±20ms 312±10ms 1.04 benchmarks.MetadataSuite.time_load_partition_info_order6
1.12±0.02s 1.14±0.01s 1.02 benchmarks.MetadataSuite.time_load_partition_info_order7
641±3ms 642±4ms 1 benchmarks.Suite.time_pixel_tree_creation
125±0.6ms 125±0.8ms 1 benchmarks.time_test_alignment_even_sky
1.85±0.02s 1.84±0.01s 0.99 benchmarks.MetadataSuite.time_load_partition_join_info
98.4±0.3ms 97.7±0.7ms 0.99 benchmarks.time_test_cone_filter_multiple_order

Click here to view all benchmarks.

Copy link
Contributor

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left some minor comments!

@delucchi-cmu delucchi-cmu merged commit 3a77c01 into main Jan 30, 2024
12 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/lsdb/107/info branch January 30, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants