Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: drop undeclared runtime dependency on setuptools #43

Closed

Conversation

neutrinoceros
Copy link

Discovered while trying to remove setuptools as a dependency in glue-core
Note that the problem is evident when testing mpl-scatter-density in a fresh env that doesn't have setuptools, e.g., using uv venv

uv venv
uv pip install -e .
source .venv/bin/activate
python -c "import mpl_scatter_density"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/clm/dev/astropy-project/deps/mpl-scatter-density/mpl_scatter_density/__init__.py", line 4, in <module>
    from pkg_resources import get_distribution, DistributionNotFound
ModuleNotFoundError: No module named 'pkg_resources'

@neutrinoceros
Copy link
Author

@astrofrog can you have a look ?

@neutrinoceros
Copy link
Author

@astrofrog I'm also fixing CI failures in #44

@astrofrog
Copy link
Owner

Thanks, feel free to also drop old Python versions if it simplifies things. 3.9 or later would be fine.

@neutrinoceros
Copy link
Author

Happy to do it as a follow up. Doing it here would actually make the patch bigger.

@neutrinoceros
Copy link
Author

@astrofrog good to go ?

@astrofrog
Copy link
Owner

@neutrinoceros Could you rebase? Thanks!

@neutrinoceros
Copy link
Author

While rebasing, I realized that the problem was already fixed in #47

@neutrinoceros neutrinoceros deleted the dep/drop_setuptools branch January 6, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants