Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move smoke tests into dedicated jobs and build uvx explicitly #10824

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jan 21, 2025

In the interest of expanding these tests and debugging weird behaviors, I've moved the smoke tests out of the cargo test job and into dedicated smoke test jobs. We explicitly build uvx in the build binary jobs instead of relying on the implicit build for the test run.

I also added a uvx test case to the smoke tests: uvx ruff --version

@zanieb zanieb added the testing Internal testing of behavior label Jan 21, 2025
@zanieb zanieb temporarily deployed to uv-test-publish January 21, 2025 20:49 — with GitHub Actions Inactive
@zanieb zanieb marked this pull request as ready for review January 21, 2025 21:16
@zanieb

This comment was marked as outdated.

@zanieb

This comment was marked as outdated.

@zanieb zanieb changed the title Explicitly build uvx in CI Move smoke tests into dedicated jobs and build uvx explicitly Jan 21, 2025
@zanieb zanieb temporarily deployed to uv-test-publish January 21, 2025 22:01 — with GitHub Actions Inactive
@zanieb zanieb requested a review from Gankra January 21, 2025 22:04
@zanieb zanieb merged commit fd16988 into main Jan 21, 2025
68 checks passed
@zanieb zanieb deleted the zb/uvx-test branch January 21, 2025 22:46
@zanieb
Copy link
Member Author

zanieb commented Jan 21, 2025

One downside of this change: these don't block CI / auto-merge anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Internal testing of behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant