Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
<!-- Thank you for contributing to uv! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary I started learning `uv` by inspecting the source code. I've noticed that your shell scripts are very good! Which is rare! ## Test Plan I propose to add `shellcheck` to the CI. It is a great tool to help finding bugs and style issues in shell code. Techincal details: - This CI job will only run when any `.sh` files are changed (or the job definition file) - It takes just several seconds even on local machine: ``` » time shellcheck -S style **/*.sh shellcheck -S style **/*.sh 0.02s user 0.05s system 61% cpu 0.123 total ``` - It is easy to use, for example: I just fixed the single problem you had in your code with `# shellcheck disable=SC1091` - I am using this tool for around 8 years now and didn't have any issues. Examples: https://github.com/sobolevn/git-secret/blob/ca899f3b694187f9027161f537414422ee99c483/.github/workflows/test.yml#L22-L27 and https://github.com/wemake-services/wemake-django-template/blob/master/.github/workflows/shellcheck.yml But, I understand that build / lint tools are very subjective. So, feel free to close :)
- Loading branch information