fix: add tsconfig root_dir/exclude validation

[Mivr]

Close #644

--

Changes are visible to end-users: yes

• Searched for relevant documentation and updated as needed: N/A
• Breaking change (forces users to change their own code or config): no
• Suggested release notes appear below: Yes

Normalize ts_project *_dir attribute paths.

Validate any use of root_dir includes the exclude: [] workaround for #644

Test plan

• New test cases added

Before the change any usage of a declaration_dir that starts with "./" was leading to an error, now if the path starts with "./" it is simply removed and the behavior is as if it was not added at all.

Before the change:

declaration_dir	tsconfig declarationDir	Result	Message
	undefined	PASS
.	undefined	PASS
./	undefined	FAIL	invalid target name './/foo.d.ts': target names may not contain '.' as a path segment
./dir	undefined	FAIL	invalid target name './dir/foo.d.ts': target names may not contain '.' as a path segment
./dir	./dir	FAIL	invalid target name './dir/foo.d.ts': target names may not contain '.' as a path segment
out	undefined	FAIL	not all outputs were created or valid
out	out	PASS
undefined	out	FAIL	not all outputs were created or valid
out	./out	PASS

After the change:

declaration_dir	tsconfig declarationDir	Result	Message
	undefined	PASS
.	undefined	PASS
./	undefined	PASS
./dir	undefined	FAIL	not all outputs were created or valid
./dir	./dir	PASS
dir	undefined	FAIL	not all outputs were created or valid
dir	dir	PASS
undefined	dir	FAIL	not all outputs were created or valid
dir	./dir	PASS

[aspect-workflows]

Test

All tests were cache hits

160 tests (100.0%) were fully cached saving 15s.

---

Buildifier      Format

[jbedard]

What about out_dir, root_dir etc? I forget if those had similar issues?

[Mivr]

What about out_dir, root_dir etc? I forget if those had similar issues?

They do have the same problems, do you prefer them in this PR or in an another one?

[Mivr]

I moved the stripping deeper in the code, now it impacts root_dir, declaration_dir and out_dir. I will test more thoroughly and post the results.