Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use specific node version for pnpm in bat-tests #756

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jan 8, 2025

It seems github workflows upgrade node and the pnpm version being used no longer works with the latest node. I had the same problem locally.


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

Copy link

aspect-workflows bot commented Jan 8, 2025

Test

All tests were cache hits

153 tests (100.0%) were fully cached saving 10s.


Buildifier      Format

@jbedard jbedard marked this pull request as ready for review January 8, 2025 23:23
@jbedard jbedard changed the title test: fix bat-tests test: use specific node version for pnpm in bat-tests Jan 8, 2025
@jbedard jbedard merged commit 60c2e54 into aspect-build:main Jan 9, 2025
20 checks passed
@jbedard jbedard deleted the bat-tests-module branch January 9, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants