Skip to content

Commit

Permalink
fix: pass --no-sandbox by default to Chromium
Browse files Browse the repository at this point in the history
We see a lot of issues with users struggling with Chromium sandboxing.
We tried fighting these with Docker configs, but it requires running
Docker with special seccomp profile.

As a result, majority ends up using `--no-sandbox` anyway. This patch
saves our users a hassle and starts using `--no-sandbox` by default.

References microsoft#2745
  • Loading branch information
aslushnikov committed Jul 18, 2020
1 parent 91e1a25 commit 3807473
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 1,540 deletions.
4 changes: 1 addition & 3 deletions docs/docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,10 @@ $ docker pull mcr.microsoft.com/playwright:bionic
### Run the image

```
$ docker container run -it --rm --ipc=host --security-opt seccomp=chrome.json mcr.microsoft.com/playwright:bionic /bin/bash
$ docker container run -it --rm --ipc=host mcr.microsoft.com/playwright:bionic /bin/bash
```

Note that:

* The seccomp profile is required to run Chrome without sandbox. Thanks to [Jessie Frazelle](https://github.com/jessfraz/dotfiles/blob/master/etc/docker/seccomp/chrome.json).
* Using `--ipc=host` is also recommended when using Chrome ([Docker docs](https://docs.docker.com/engine/reference/run/#ipc-settings---ipc)). Chrome can run out of memory without this flag.

### Using on CI
Expand Down
Loading

0 comments on commit 3807473

Please sign in to comment.