Changes based on Codacy code scanning warnings

util.sh warnings
- https://github.com/forcedotcom/dataloader/security/code-scanning/217
- https://github.com/forcedotcom/dataloader/security/code-scanning/222
- https://github.com/forcedotcom/dataloader/security/code-scanning/225

dlbuilder.sh warnings
- https://github.com/forcedotcom/dataloader/security/code-scanning/218

dlbuilder.sh

@@ -6,7 +6,7 @@ run_mvn() {
   # run a mvn build to download dependencies from the central maven repo
   mvn clean compile
   # remove vulnerable class from log4j jar file
-  log4j_version_num=`awk '/<artifactId>log4j-core/{getline; print}' pom.xml | awk '{$1=$1};1' `
+  log4j_version_num=$(awk '/<artifactId>log4j-core/{getline; print}' pom.xml | awk '{$1=$1};1' )
   log4j_version_num=${log4j_version_num#<version>};
   log4j_version_num=${log4j_version_num%</version>};
 

src/main/resources/mac/util/util.sh

@@ -19,7 +19,7 @@ checkJavaVersion() {
     initVars
 
     echo "Data Loader requires Java JRE ${MIN_JAVA_VERSION} or later. Checking if it is installed..."
-    if [ ! -z "${DATALOADER_JAVA_HOME}" ]
+    if [ -n "${DATALOADER_JAVA_HOME}" ]
     then
         JAVA_HOME=${DATALOADER_JAVA_HOME}
     fi
@@ -43,11 +43,11 @@ exitWithJavaDownloadMessage() {
     echo "Java JRE ${MIN_JAVA_VERSION} or later is not installed or DATALOADER_JAVA_HOME environment variable is not set."
     echo "For example, download and install Zulu JRE ${MIN_JAVA_VERSION} or later from here:"
     echo "    https://www.azul.com/downloads/"
-    exit -1
+    exit 1
 }
 
 runDataLoader() {
     checkJavaVersion
     SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
-    java -cp "${SCRIPT_DIR}/../*" com.salesforce.dataloader.process.DataLoaderRunner $@
+    java -cp "${SCRIPT_DIR}/../*" com.salesforce.dataloader.process.DataLoaderRunner "$@"
 }