Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrappers for
VK_KHR_video{,_encode,_decode}_queue
#965base: master
Are you sure you want to change the base?
Add wrappers for
VK_KHR_video{,_encode,_decode}_queue
#965Changes from all commits
f492cd5
f17b15f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to call out that this doesn't work if you don't consume
self
, because&mut T
is notCopy
(that would be aliasing). However, that makes this slightly inconsistent with regards toRawPtr
(just above).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if
trait RawPtr
should takeself
by value too, given thatOption<&T>
isCopy
(and we don't have&Option<&T>
).Locally this violates
clippy::wrong_self_convention
though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah, I missed that lint. I could change both to
to_...
or just doRawMutPtr::to_raw_mut_ptr
and leaveRawPtr
as it is.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since both are private helpers, I'm not opposed to unifying both into a
to_
.