-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix locate endpoint bucket name test #802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattp0
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Option 1 seems like the best for a breaking change. We could continue to support 1.3.x and bump the version here to 2.x?
reweeden
force-pushed
the
rew/locate-bucket-name-prefix
branch
from
March 19, 2024 19:03
4cca69b
to
ff01366
Compare
gjclark
approved these changes
Mar 19, 2024
mckadesorensen
approved these changes
Mar 19, 2024
reweeden
force-pushed
the
rew/locate-bucket-name-prefix
branch
from
March 19, 2024 20:33
36c614d
to
2e7dc21
Compare
reweeden
force-pushed
the
rew/locate-bucket-name-prefix
branch
from
March 19, 2024 20:43
2e7dc21
to
152b7ad
Compare
reweeden
force-pushed
the
rew/locate-bucket-name-prefix
branch
from
March 19, 2024 20:52
152b7ad
to
4092e31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#777 introduced a change to how the locate endpoint works with respect to the
BucketnamePrefix
parameter. Previously thebucket
parameter expected the name of the bucket WITHOUT the prefix. This is arguably not the desired behavior as it requires the caller of the application to know which part of the bucket name is the prefix and to be able to strip it out in the request. However, this does create a breaking change in the API so we have a few options:I think option 1 is the way to go for now. Even though this is a breaking change, AFAIK CIRRUS/cumulus doesn't use the
BucketnamePrefix
parameter, so those deployments won't be affected and Sentinel doesn't use thelocate
endpoint so those deployments shouldn't be affected either. If there are some affected deployments out there they'll have the warning of the version number bump and they can ask for support in upgrading.