Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simple version comparison for tag validation #838

Closed
wants to merge 3 commits into from
Closed

simple version comparison for tag validation #838

wants to merge 3 commits into from

Conversation

CagtayFabry
Copy link
Contributor

@CagtayFabry CagtayFabry commented Jul 29, 2020 •
edited
Loading

very simple implementation for version parsing discussed in asdf-format/asdf-standard#271
This should enable the following syntax to work:

tag: http://stsci.edu/schemas/asdf/core/software-* # allow every version
tag: http://stsci.edu/schemas/asdf/core/software-1 # fix major version
tag: http://stsci.edu/schemas/asdf/core/software-1.2 # fix minor version
tag: http://stsci.edu/schemas/asdf/core/software-1.2.3 # fix patch version

@CagtayFabry CagtayFabry mentioned this pull request Jul 30, 2020
Open
@eslavich eslavich mentioned this pull request Aug 10, 2020
Merged
@CagtayFabry
Copy link
Contributor Author

closing this in favor of #858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CagtayFabry