Make lib/poetry-lock/poetry-lock-all.sh failures more obvious
#1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-anderson
approved these changes
Jan 14, 2025
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| root="$(pwd)" | |||
| fail() { | |||
| echo FAILED | |||
There was a problem hiding this comment.
I'd do this: echo "FAILED: $@"
To make it a little harder to miss.
or if you think people will be bad at reading:
echo FAILED FAILED FAILED FAILED
echo "$@"
echo FAILED FAILED FAILED FAILED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, first time users who hadn't read the script could see the output abruptly stop and assume the script had completed successfully. Now, it will always either output a SUCCESS or a FAILED near the end of the output.