Allow OpenSearchReader to output to MaterializedDataset consisting of refs #1029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sycamore connectors (implementations of BaseDBReader) produce MaterializedDataset (
from_items
)sycamore/lib/sycamore/sycamore/connectors/base_reader.py
Line 83 in 6039f8c
and this creates an issue when working with queries that need to scan a large number of documents.
Largely, we can take two approaches to addressing this problem. We can try to reduce the amount of data that get loaded into memory when constructing a MaterializedDataset by only serializing references to the docs and then when we deserialize, we fetch the docs from storage on-demand.
Alternatively, we can introduce a custom Datasource, e.g. SqlDatasource and MongoDatasource, for each of our connectors. With this approach, we can achieve streaming and read parallelism that is native to Ray.
In this PR, I demonstrate a working example of the first approach for the OpenSearch reader/connector.